Conversation
- Remove timestamp reset from empty() method in both event systems - Add resetTimestamp() method for explicit session clear - Update tests for new behavior - Ensures session attributes sent on every harvest after first 60s Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Replace kDefaultBufferSize (event count) with kMillisecondsPerSecond - kDefaultBufferSize was semantically incorrect for time conversion - Both equal 1000 so behavior unchanged, but now semantically correct Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
|
||
| ASSERT_THROW(manager.newEvent(strs2), std::runtime_error); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Nice! I forgot about libMobileAgent C++ tests, they will go away once we make NewEventSystem default and remove the new event system flag. Excellent work getting coverage.
cdillard-NewRelic
previously approved these changes
Feb 18, 2026
Updates session replay to report correct platform information for hybrid agents: - instrumentation.name: Uses platform-aware logic (native vs hybrid) - instrumentation.version: Uses platformVersion with fallback to agentVersion - Matches NRLogger pattern for consistent reporting across all data types This ensures hybrid agents (React Native, Flutter, Capacitor, etc.) are correctly identified with their platform version in session replay data. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Author
|
Added the changes to the SessionReplayReporter for instrumentation.name, instrumentation.version and collector.name, to match everything else. |
Member
|
Awesome use of blocks in SessionReplay 👍 |
mbruin-NR
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes session attributes not being sent consistently across harvests, ensuring
platformVersionis used forinstrumentation.versioninstead of falling back to native agent version. Session attributes were only populated whenhandleHarvest()was triggered by specific conditions. Harvests containing only metrics/HTTP requests (no events) sent empty session attributes{}.Changes
1. Preserve Event Timestamp Across Harvests
empty()method (both event systems)resetTimestamp()method for explicit session clear2. Fix Logger Instrumentation Version
NRLogger.mto useplatformVersionwith fallback toagentVersion3. Fix Time Conversion Constant
kDefaultBufferSize(event count) withkMillisecondsPerSecondindidReachMaxQueueTime()Testing